On Thu, Jun 27, 2013 at 05:19:37PM +0400, Sergei Shtylyov wrote: > Hello. > > On 27-06-2013 3:30, Greg Kroah-Hartman wrote: > > >Use the pr_* calls instead, which are much more descriptive. > > >Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > >--- > > drivers/usb/misc/adutux.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > >diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c > >index b152581..3105f18 100644 > >--- a/drivers/usb/misc/adutux.c > >+++ b/drivers/usb/misc/adutux.c > [...] > >@@ -235,8 +237,8 @@ static int adu_open(struct inode *inode, struct file *file) > > > > interface = usb_find_interface(&adu_driver, subminor); > > if (!interface) { > >- printk(KERN_ERR "adutux: %s - error, can't find device for " > >- "minor %d\n", __func__, subminor); > >+ pr_err("%s - error, can't find device for minor %d\n", > >+ __func__, subminor); > > In legotower.c you removed __func__ in the alike case, here you > left it alone. Seems somewhat inconsistent. Yes it is. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html