On Wed, Jun 26, 2013 at 09:32:47AM +0200, Tim Sander wrote: > Hi > > I have just written a ehci testing driver which enables the testing modes used > for hw testing via a file in debugfs. This patch is for 3.4.47 not any usb > branch. But if this driver is ready for mainline i will be happy to port it to > whatever branch you wish. > > The only problem with the patch is that it is currently working on hw registers > as the usb control msg in this patch is not working. For the time beeing i just > commented out the usb_control_msg call and fiddled with the registers directly. > This is one thing which might not be mainline compatible? > > The call not working is: > status = usb_control_msg(hub, usb_sndctrlpipe(hub,0), > USB_REQ_SET_FEATURE, USB_RT_PORT, USB_PORT_FEAT_TEST, > i << 8 | hub->portnum, NULL, 0, 1000); > ^^^^^^^^^^^^^^^^^ this might be wrong? Where is this call you are referring to? I don't see it in the patch you have below. > I have the strong suspicion that the marked agument is wrong? The direct manipulation > of the portsc register works as expected. > > The testmodes array is magic in a way that the offset of the values corresponds directly > with the PTC field (Bits 19-16) of the Port Status Control register. > > Also there is a driver which does the tests with a special usb test plug: > http://code.google.com/p/bricked/source/browse/drivers/usb/misc/ehset.c > Its also sending these usb_control_msg but these are also not working. > > So if this usb_control_msg is working it would also be nice to get this driver mainlined. I agree, care to make it up into a patch we could apply? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
