On Tue, 25 Jun 2013, Sarah Sharp wrote: > > Maybe this loop isn't needed. Would it be okay to call > > usb_enable_intel_xhci_ports() even if there are no EHCI controllers? > > Probably not. If there are no EHCI controllers, the xHCI host is > unlikely to have the port switchover registers in its PCI config space. > That means we would be reading and writing to registers we have no idea > what they do. > > The code at the end of this patch also needs to check for Intel EHCI > controllers on xHCI resume: > > - if (usb_is_intel_switchable_xhci(pdev)) > - usb_enable_xhci_ports(pdev); > + > + if (pdev->vendor == PCI_VENDOR_ID_INTEL) > + usb_enable_intel_xhci_ports(pdev); > > > For that matter, what happens if there aren't any "companion" EHCI > > controllers for the xHCI controller in question, but there are separate > > EHCI controllers on an add-on PCI card? > > They wouldn't be Intel EHCI controllers. We don't make discrete host > controllers. If that changes, we can revisit this, but I don't think > it's an issue. Okay then. Mathias, when you incorporate Sarah's suggestion you can add: Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
