On Tue, Jun 25, 2013 at 04:27:18PM +0530, navin patidar wrote: > On Tue, Jun 25, 2013, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> said: > > > On Fri, Jun 21, 2013 at 03:01:04PM +0530, navin patidar wrote: > >> pr_warn() is preferred over pr_warning(). > > > > And dev_warn() is preferred over both of them, can you convert the code > > to use that instead? > > > > struct device is not available in usbip_start_eh() which is required > for dev_warn(). > > usbip_device's containers struct stub_device and struct vhci_device > both have member structure usb_device but inside usbip_start_eh(), it > is difficult to determine to which container struct usbip_device > belongs, thus container_of() can not be used here to get struct > usb_device. Then the code should be reworked in order to be able to properly determine that. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
