Re: [v4] usb: UHCI: fix pkt size in TD for a sg element

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 24, 2013 at 10:33 PM, Denis V. Lunev <den@xxxxxxxxxx> wrote:
> From: Konstantin Filatov <kfilatov@xxxxxxxxxxxxx>
>
> This patch shortens TD's packet not only for the last TD in sg list,
> but also for the last TD in sg element.
>
> Signed-off-by: Konstantin Filatov <kfilatov@xxxxxxxxxxxxx>
> Signed-off-by: Denis V. Lunev <den@xxxxxxxxxx>

Considered that:

- the change violates USB spec(1.1/2.0/3.0)
- the problem should be avoided in usbcore since it isn't a uhci
specific problem
- this patch only hides problem, doesn't help to fix real problem.

so NAK.

I will cook a patch to prevent such bad sg list from reaching HCDs tomorrow.

Thanks,
-- 
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux