Re: [v2] usb: UHCI: fix pkt size in TD for a non-aligned sg element

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 22, 2013 at 12:13 AM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, 21 Jun 2013, Ming Lei wrote:
>
> I'm not sure what you mean.  Do you mean that usb_sg_init() should fail
> if the SG element length isn't a multiple of the maxpacket size?  That
> probably will break wireless USB.
>
> Do you mean that usb_sg_init() should break the transfer up into a
> bunch of separate URBs in this case (the way it does when the HCD
> doesn't have native support for SG)?  That won't work because one of
> the URBs would have a transfer length that wasn't a multiple of the
> maxpacket size.

Yes.

Sorry, could you explain why that won't work? I understand the URBs
with maxp-unaligned length still can be completed.

>
> Furthermore, URBs using SG can be submitted directly, without going
> through usb_sg_init() at all.  So changing usb_sg_init() won't fix the
> problem.

Looks usbtest use it, so the reported problem can be fixed.


Thanks,
-- 
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux