On Wed, 19 Jun 2013, Ming Lei wrote: > On Wed, Jun 19, 2013 at 12:36 AM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, 18 Jun 2013, Ming Lei wrote: > > > >> We disable local IRQs here in case of running complete() by > >> tasklet to avoid possible deadlock because drivers may call > >> spin_lock() to hold lock which might be acquired in one hard > >> interrupt handler. > >> > >> The local_irq_save()/local_irq_restore() around complete() > >> will be removed if current USB drivers have been cleaned up > >> and no one may trigger the above deadlock situation when > >> running complete() in tasklet. > > > > This should be part of the first patch, not added on separately. > > Yes, but I want to highlight the change since that will be removed > after drivers have been cleaned up. I don't think it's necessary to highlight anything, and it seems silly to add new code in one patch and then change it in the very next patch. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
