Re: [PATCH V3 05/11] USB: OHCI: Properly handle ohci-ep93xx suspend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19 June 2013 20:12, Manjunath Goudar <manjunath.goudar@xxxxxxxxxx> wrote:
> On 19 June 2013 18:13, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
>> On 19-06-2013 16:12, Manjunath Goudar wrote:

>>>         struct usb_hcd *hcd = platform_get_drvdata(pdev);
>>>         struct ohci_hcd *ohci = hcd_to_ohci(hcd);
>>> +       bool    do_wakeup = device_may_wakeup(&pdev->dev);
>>> +       int             ret;
>>
>>
>>    There was no need to use tabs here, didn't you see that here the
>> variables aren't aligned?

> Instead of gmail you can use thunderbird mail there it is showing  proper
> alignment.

First try to understand what the actual comment is. He isn't complaining
about bad alignment but as hcd and ohci aren't aligned with tabs, you
don't require to add tabs to do_wakeup and ret.

--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux