On 19/06/13 10:12, Jiri Slaby wrote: > On 06/19/2013 09:10 AM, Tomi Valkeinen wrote: >> On 17/06/13 23:05, Jiri Slaby wrote: >> >>> The last point I inclined to the Greg's argument to remove the >>> EXPERT dependency. >>> >>> So currently I have what is attached... Comments? >> >> The patch looks a bit odd with the USB_CHIPIDEA_IMX parts. You're >> not adding COMPILE_TEST there, but you're adding a totally new >> config option, and also changing the Makefile. > > Look: > > +config USB_CHIPIDEA_IMX > + bool "ChipIdea IMX support" > + depends on OF_DEVICE && (ARM || COMPILE_TEST) > > COMPILE_TEST added here ----------------^^^^^^^^^^^^ My point was that you're not adding COMPILE_TEST to an existing config option, you're creating a totally new config option. As I said, that's probably ok, but it'd be nice to mention extra things like that in the desc. The pedantic approach would be to do the makefile and Kconfig change in an earlier patch, and then add only COMPILE_TEST. Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
