On Wed, Jun 19, 2013 at 09:25:27AM +0300, Felipe Balbi wrote:
> On Wed, Jun 19, 2013 at 10:11:05AM +0800, Peter Chen wrote:
> > on i386:
> >
> > drivers/built-in.o: In function `ci_hdrc_probe':
> > core.c:(.text+0x20446b): undefined reference to `of_usb_get_phy_mode'
> >
> > Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>
> > ---
> > include/linux/usb/of.h | 14 +++++++++-----
> > 1 files changed, 9 insertions(+), 5 deletions(-)
> >
> > diff --git a/include/linux/usb/of.h b/include/linux/usb/of.h
> > index e460a24..a0aa1c8 100644
> > --- a/include/linux/usb/of.h
> > +++ b/include/linux/usb/of.h
> > @@ -11,18 +11,22 @@
> > #include <linux/usb/phy.h>
> >
> > #ifdef CONFIG_OF
>
> let's use IS_ENABLED() here
>
> > -enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np);
> > enum usb_dr_mode of_usb_get_dr_mode(struct device_node *np);
> > #else
> > -static inline enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np)
> > +static inline enum usb_dr_mode of_usb_get_dr_mode(struct device_node *np)
> > {
> > - return USBPHY_INTERFACE_MODE_UNKNOWN;
> > + return USB_DR_MODE_UNKNOWN;
> > }
> > +#endif
> >
> > -static inline enum usb_dr_mode of_usb_get_dr_mode(struct device_node *np)
> > +#if defined(CONFIG_OF) && defined(CONFIG_USB_PHY)
>
> and here
Will change
>
> > +enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np);
> > +#else
> > +static inline enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np)
> > {
> > - return USB_DR_MODE_UNKNOWN;
> > + return USBPHY_INTERFACE_MODE_UNKNOWN;
> > }
> > +
> > #endif
>
> Also, why can't the same problem happen with of_usb_get_dr_mode() ??
It is only related to CONFIG_OF, no relationship with other
configs.
--
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
