On Wed, Jun 19, 2013 at 10:48 AM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Tue, Jun 18, 2013 at 10:31:20PM -0400, Chao Xie wrote: >> Some controller need software to initialize PHY before add >> host controller, and shut down PHY after remove host controller. >> Add the generic code for these controllers so they do not need >> do it in its own host controller driver. > > Why? What breaks if we add this patch, and what gets fixed? I'm > guessing you can then remove code? > > What out-of-tree code now works properly? Or gets broken? > > we need more info here please... > The patch does not fix any bug. Some echi-xxx driver will need initialize the phy before it do usb_add_hcd, and shut down phy after do usb_remove_hcd, and i did a patch for ehci-mv.c to do above thing. Alan and Felipe comments on my patch, and they think it is a peice of generic code, and it can be moved to hcd to handle it, so other ehci-xxx will not do the same thing again. So i add the patch to add the generic code in hcd to handle phy initialization and shut down. > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
