RE: [PATCH -next] usb: gadget: f_subset: fix missing unlock on error in geth_alloc()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, June 18, 2013 5:41 AM Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> 
> Add the missing unlock before return from function geth_alloc() in the
> error handling case.
> 
> Introduced by commit 02832e56f88a981474ee4c7c141f46fc1b4454f4.
> (usb: gadget: f_subset: add configfs support)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>

Thank you for pointing this out,

Acked-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx>

> ---
>  drivers/usb/gadget/f_subset.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/gadget/f_subset.c b/drivers/usb/gadget/f_subset.c
> index fbc7a24..5601e1d 100644
> --- a/drivers/usb/gadget/f_subset.c
> +++ b/drivers/usb/gadget/f_subset.c
> @@ -548,6 +548,7 @@ static struct usb_function *geth_alloc(struct
> usb_function_instance *fi)
>  					  sizeof(geth->ethaddr));
>  	if (status < 12) {
>  		kfree(geth);
> +		mutex_unlock(&opts->lock);
>  		return ERR_PTR(-EINVAL);
>  	}
>  	geth_string_defs[1].s = geth->ethaddr;


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux