On Fri, Jun 14, 2013 at 02:23:36PM -0700, Greg KH wrote: > On Fri, Jun 14, 2013 at 02:16:50PM -0700, Sarah Sharp wrote: > > The main thing I'm concerned about is that the patch doesn't handle > > Intel xHCI host controller PCI hot-plug. We don't really expect any of > > the Intel PCI hosts to be hot-removed, since they are part of the > > chipset, but we could dereference a stale pointer if the host was > > hot-removed. > > So will there never be add-on PCI Express cards with the Intel host > controller on them? What about Expressbus? I have a EHCI Expressbus > device around here somewhere... I don't know the answer to that question, but I doubt it. I do have a PCI Express card, but it's a non-Intel host. I don't think it would make sense to have a port switchover with an add-in card anyway. The customer that buys the card would be expecting to install a separate Windows driver for it, so there's no reason to fall back to EHCI. > > If you think that I shouldn't be that defensive about the code, I'm fine > > with taking the patch as-is. > > We should be able to handle hotplug if at all possible. I know the > quirk handling issues around PCI hotplug aren't all worked out (or at > least they were not a year or so ago), so maybe there's really nothing > you can/need to do here. Ok, I'll work with Mathias, and we'll figure out how to handle hot plug. If you have any good suggestions, let me know. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
