On Fri, 14 Jun 2013, Thierry Reding wrote: > Under some circumstances it happens that the connected PHY can't be > powered up properly, in which case the cleanup path currently crashes > because it checks the tegra->transceiver field using !IS_ERR(), which > will succeed because it is in fact NULL. Dereferencing that pointer > causes an oops in tegra_ehci_probe(). > > This patch fixes the issue by adding an additional label into the > cleanup path to separately take down the PHY and the transceiver. > > Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxx> Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> This looks a lot like a repeat of 369a9a9d2af7 (usb: host: ehci-tegra: Fix oops in error cleanup). Evidently someone wasn't very careful when changing the names of the statement labels. Or maybe a merge conflict was resolved incorrectly. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
