Re: [PATCH 1/3] usb: chipidea: add CSR SiRFSoC ci13xxx usb driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Barry Song <21cnbao@xxxxxxxxx> writes:

> 2013/6/14 Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>:
>> Barry Song <21cnbao@xxxxxxxxx> writes:
>>
>>> +if USB_CHIPIDEA_UDC && USB_CHIPIDEA_HOST
>>> +
>>> +config USB_CHIPIDEA_SIRF
>>> +     depends on ARCH_SIRF
>>> +     bool "SiRF USB controller ChipIdea driver binding"
>>> +     default y
>>> +     help
>>> +       Say Y here to enable sirf usb ChipIdea driver binding.
>>> +
>>> +config USB_CHIPIDEA_MSM
>>> +     depends on ARCH_MSM
>>> +     bool "MSM USB controller ChipIdea driver binding"
>>> +     default y
>>> +     help
>>> +       Say Y here to enable msm usb ChipIdea driver binding.
>>> +
>>> +config USB_CHIPIDEA_IMX
>>> +     depends on ARCH_MXC || ARCH_MXS
>>> +     bool "i.MX USB controller ChipIdea driver binding"
>>> +     default y
>>> +     help
>>> +       Say Y here to enable imx usb ChipIdea driver binding.
>>> +
>>> +endif
>>
>> No. This is wrong on at least 3 different levels.
>
> the point is we don't directly include MSM, IMX, SiRF and all other
> drivers once we enable chipidea. that makes these drivers optional,
> not always be built-in.

This has been discussed several times already. Just set the
USB_CHIPIDEA=m and then everything will be built as modules and nothing
will be built in. What exactly is the problem you're trying to solve
with this?

The only way something like this will go in is with Jiri's COMPILE_TEST
patchset. This snippet above is just buggy.

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux