Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> writes:
> Hello.
>
> On 06/13/2013 06:59 PM, Alexander Shishkin wrote:
>
>> From: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
>
>> The pdata structure gets copied anyway inside ci13xxx_add_device
>> by platform_device_add. We don't need to have it static.
>
>> Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
>> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
>> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
>> Reviewed-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>
>> Signed-off-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
>> ---
>> drivers/usb/chipidea/ci13xxx_imx.c | 19 +++++++++----------
>> 1 file changed, 9 insertions(+), 10 deletions(-)
>
>> diff --git a/drivers/usb/chipidea/ci13xxx_imx.c b/drivers/usb/chipidea/ci13xxx_imx.c
>> index 9cecfd5..18d83ab 100644
>> --- a/drivers/usb/chipidea/ci13xxx_imx.c
>> +++ b/drivers/usb/chipidea/ci13xxx_imx.c
>> @@ -87,17 +87,16 @@ EXPORT_SYMBOL_GPL(usbmisc_get_init_data);
>>
>> /* End of common functions shared by usbmisc drivers*/
>>
>> -static struct ci13xxx_platform_data ci13xxx_imx_platdata = {
>> - .name = "ci13xxx_imx",
>> - .flags = CI13XXX_REQUIRE_TRANSCEIVER |
>> - CI13XXX_PULLUP_ON_VBUS |
>> - CI13XXX_DISABLE_STREAMING,
>> - .capoffset = DEF_CAPOFFSET,
>> -};
>> -
>> static int ci13xxx_imx_probe(struct platform_device *pdev)
>> {
>> struct ci13xxx_imx_data *data;
>> + struct ci13xxx_platform_data pdata = {
>> + .name = "ci13xxx_imx",
>> + .capoffset = DEF_CAPOFFSET,
>> + .flags = CI13XXX_REQUIRE_TRANSCEIVER |
>> + CI13XXX_PULLUP_ON_VBUS |
>> + CI13XXX_DISABLE_STREAMING,
>> + };
>
> Don't think that's a good idea. This will cause some code bloat.
They can have more than one instance of chipidea, so they'll need it
sooner or later.
Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
