On 06/13/2013 01:37 AM, Greg KH wrote: > On Wed, Jun 12, 2013 at 02:31:17PM -0700, Greg KH wrote: >> On Thu, Jun 13, 2013 at 12:19:02AM +0300, Felipe Balbi wrote: >>> Hi, >>> >>> On Wed, Jun 12, 2013 at 11:56:19PM +0300, Felipe Balbi wrote: >>>>> But, I get a build error with your tree pulled in, at the link point in >>>>> time: >>>>> >>>>> ERROR: "usb_add_phy" [drivers/usb/phy/phy-samsung-usb3.ko] undefined! >>>>> ERROR: "usb_remove_phy" [drivers/usb/phy/phy-samsung-usb3.ko] undefined! >>>>> ERROR: "usb_add_phy" [drivers/usb/phy/phy-samsung-usb2.ko] undefined! >>>>> ERROR: "usb_remove_phy" [drivers/usb/phy/phy-samsung-usb2.ko] undefined! >>>>> ERROR: "usb_add_phy" [drivers/usb/phy/phy-rcar-usb.ko] undefined! >>>>> ERROR: "usb_remove_phy" [drivers/usb/phy/phy-rcar-usb.ko] undefined! >>>>> ERROR: "usb_remove_phy" [drivers/usb/phy/phy-omap-usb3.ko] undefined! >>>>> ERROR: "usb_add_phy_dev" [drivers/usb/phy/phy-omap-usb3.ko] undefined! >>>>> ERROR: "usb_add_phy_dev" [drivers/usb/phy/phy-nop.ko] undefined! >>>>> ERROR: "usb_remove_phy" [drivers/usb/phy/phy-nop.ko] undefined! >>>>> ERROR: "usb_add_phy_dev" [drivers/usb/phy/phy-isp1301.ko] undefined! >>>>> ERROR: "usb_remove_phy" [drivers/usb/phy/phy-isp1301.ko] undefined! >>>>> ERROR: "usb_add_phy" [drivers/usb/phy/phy-gpio-vbus-usb.ko] undefined! >>>>> ERROR: "usb_remove_phy" [drivers/usb/phy/phy-gpio-vbus-usb.ko] undefined! >>>>> ERROR: "usb_get_phy" [drivers/usb/musb/ux500.ko] undefined! >>>>> ERROR: "usb_put_phy" [drivers/usb/musb/ux500.ko] undefined! >>>>> ERROR: "usb_put_phy" [drivers/usb/gadget/pxa27x_udc.ko] undefined! >>>>> ERROR: "usb_get_phy" [drivers/usb/gadget/pxa27x_udc.ko] undefined! >>>>> ERROR: "devm_usb_get_phy" [drivers/usb/gadget/mv_udc.ko] undefined! >>>>> ERROR: "devm_usb_get_phy" [drivers/usb/dwc3/dwc3.ko] undefined! >>>>> ERROR: "devm_usb_get_phy_by_phandle" [drivers/usb/dwc3/dwc3.ko] undefined! >>>>> ERROR: "usb_get_phy" [drivers/usb/chipidea/ci_hdrc.ko] undefined! >>>>> ERROR: "usb_put_phy" [drivers/usb/chipidea/ci_hdrc.ko] undefined! >>>>> ERROR: "usb_get_phy" [drivers/power/isp1704_charger.ko] undefined! >>>>> ERROR: "usb_put_phy" [drivers/power/isp1704_charger.ko] undefined! >>>>> >>>>> Any ideas? >>>> >>>> hmm... I think it was Roger's patches changing the way PHY layer is >>>> enabled, do you mind if I drop that for now ? I would have to rebase, >>>> but I guess it's a necessary evil at this point. >>> >>> I took the silence as a yes and pushed a new tag with Roger's patches >>> removed. I have also removed one musb patch which wasn't necessary after >>> all. >> >> Sorry for the silence, I went to lunch :) >> >>> Here's an updated pull request, which I have compiled on ARM and x86 >>> and didn't see the linking problem mentioned above: >> >> Ok, thanks, I'll try it out now... > > That worked, now pulled and pushed out, thanks. Hi Greg, I tried to reproduce the above problem but couldn't. Could you please share your .config that caused the issue and the command sequence you used to arrive at the problem? Thanks. By any chance is it possible that there were some stale modules lying around in your tree? The problem shouldn't happen because the symbols are defined in phy.c (USB_PHY) which is selected by the PHY drivers. Even if USB_PHY is not selected, the functions (except usb_add/remove_phy() are defined as inlines in /include/linux/usb/phy.h cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
