[PATCH fix 0/3] Configfs support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Felipe, Hello Greg,

I've seen that you pulled a bunch of my patches. That's nice.

However, Felipe was unable to apply one of them due to some whitespace issues,
so he dropped it.

While dropping the said patch does not break anything, it makes the usb
functions configurable through configfs unavailable to be built
stand-alone. They still can be built but only as a side effect of building
some old gadgets which depend on the functions of interest, e.g. ecm,
ecm subset, eem, rndis will be built as a side effect of building g_ether.ko.

In Kconfig the problem described here manifests itself by some USB_CONFIGFS_*
entries being dependent on nonexistent USB_CONFIGFS. In practice they do not
appear in menuconfig, so they can't be selected.

This isn't terribly bad, but the goal of configfs integration is to allow
composing the gadgets of functions of choice at runtime, provided that
the functions themselves are compiled. Which, in turn, stops the
proliferation of new g_xxxx.ko gadgets and, ultimately, allows
dropping the g_xxxx.ko modules at all. And this is in contradiction
to not being able to build only f_xxxx.ko modules without building some
g_xxxx.ko gadgets.

The series I'm sending does the following:

1) fix separate building of configfs-enabled functions
2) add a piece of documentation about configfs-based usb gadgets
3) add some Documentation/ABI/* related to the newly added configfs entries

I kindly ask you to consider the series; either as a whole, or individual
patches. The patches in the series do not depend on each other. Verified by
checkpatch.

Thanks,

Andrzej

Andrzej Pietrasiewicz (3):
  usb/gadget: Kconfig: fix separate building of configfs-enabled
    functions
  Documentation/usb: gadget_configfs
  Documentation/ABI/testing: configfs-based usb gadgets

 Documentation/ABI/testing/configfs-usb-gadget      |   81 ++++
 Documentation/ABI/testing/configfs-usb-gadget-acm  |    8 +
 Documentation/ABI/testing/configfs-usb-gadget-ecm  |   16 +
 Documentation/ABI/testing/configfs-usb-gadget-eem  |    2 +-
 Documentation/ABI/testing/configfs-usb-gadget-ncm  |   15 +
 Documentation/ABI/testing/configfs-usb-gadget-obex |    9 +
 .../ABI/testing/configfs-usb-gadget-phonet         |    2 +-
 .../ABI/testing/configfs-usb-gadget-rndis          |    2 +-
 .../ABI/testing/configfs-usb-gadget-serial         |    9 +
 .../ABI/testing/configfs-usb-gadget-subset         |    2 +-
 Documentation/usb/gadget_configfs.txt              |  384 ++++++++++++++++++++
 drivers/usb/gadget/Kconfig                         |   64 ++++
 12 files changed, 590 insertions(+), 4 deletions(-)
 create mode 100644 Documentation/ABI/testing/configfs-usb-gadget
 create mode 100644 Documentation/ABI/testing/configfs-usb-gadget-acm
 create mode 100644 Documentation/ABI/testing/configfs-usb-gadget-ecm
 create mode 100644 Documentation/ABI/testing/configfs-usb-gadget-ncm
 create mode 100644 Documentation/ABI/testing/configfs-usb-gadget-obex
 create mode 100644 Documentation/ABI/testing/configfs-usb-gadget-serial
 create mode 100644 Documentation/usb/gadget_configfs.txt

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux