Kishon > Cc: linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Balbi, Felipe > Subject: Re: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform >> + >> + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy_wkup"); >> + phy->phy_wkup = ioremap(res->start, resource_size(res)); >devm_ioremap? The phy_wakeup register is common across two instances of phy, devm_ioremap_resource() will fail to map for twice for same register space. >> + if (IS_ERR(phy->phy_wkup)) >> + return PTR_ERR(phy->phy_wkup); >> + >> + if (np) >> + of_property_read_u32(np, "id", &phy->id); > Is this property documented somewhere? Not it is not documented. >> + >> + phy->phy.dev = phy->dev; >> + phy->phy.label = "dsps-usbphy"; >> + dsps_usbphy_power(&dsps_phy->phy, 0); >> + dsps_phy->is_suspended = 1; > Are you using this "is_suspended" anywhere else? Currently not used. -- Ravi B -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
