On Fri, 7 Jun 2013, Manjunath Goudar wrote: > Separate the TI OHCI OMAP3 host controller driver from ohci-hcd > host code so that it can be built as a separate driver module. > This work is part of enabling multi-platform kernels on ARM. > @@ -185,7 +118,16 @@ static int ohci_hcd_omap3_probe(struct platform_device *pdev) > pm_runtime_enable(dev); > pm_runtime_get_sync(dev); > > - ohci_hcd_init(hcd_to_ohci(hcd)); > + ohci = hcd_to_ohci(hcd); > + /* > + * RemoteWakeupConnected has to be set explicitly before > + * calling ohci_run. The reset value of RWC is 0. > + */ > + ohci->hc_control = OHCI_CTRL_RWC; > + writel(OHCI_CTRL_RWC, &ohci->regs->control); > + dev_dbg(hcd->self.controller, "starting OHCI controller\n"); > + > + ohci_setup(hcd); Don't call ohci_setup(). Apart from that (and the comment format), this is okay. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
