On Fri, Jun 07, 2013 at 12:00:47PM +0200, Johan Hovold wrote:
> On Thu, Jun 06, 2013 at 10:31:21AM -0700, Greg KH wrote:
> > From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> > @@ -1040,11 +1044,10 @@ static int usb_serial_probe(struct usb_i
> > */
> > serial->disconnected = 1;
> >
> > - if (get_free_serial(serial, num_ports, &minor) == NULL) {
> > + if (get_free_serial(serial, num_ports)) {
> > dev_err(ddev, "No more free serial devices\n");
> > goto probe_error;
> > }
> > - serial->minor = minor;
>
> This gives a warning as minor is no longer initialised, but is still
> used to initialise the console a bit further down.
>
> usb_serial_console_init(minor);
>
> Should probably just drop minor, and use serial->port[0]->minor instead.
Ah crap, I knew I was going to have to convert the console code, but I
just forgot about it as I didn't have it selected so I didn't get any
build errors...
I'll go fix that up and do a v3 of the patches...
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
