Re: [PATCH v8 2/3] ARM: shmobile: r8a7778: add USB support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 04-06-2013 9:45, Kuninori Morimoto wrote:

The ohci/ehci resource will be  used vainly if platform doesn't have USB

     The platform device resources are never used vainly. And remember
that if PHY doesn't get registered, OHCI/EHCI won't get probed
successfully either -- mind the usb_power_on() platform method.

?
Could you please teach me who/how/when free resource memory
which was kmemdup'ed by platform_device_add_xxx()
(and kmalloc'ed dma_mask) on platform_device_register_full() ??

   I don't think there's a need to free them. The EHCI/OHCI devices
are always there after all.

ohci/ehci and phy should be registered in same time/function.

    I just copied your approach from the R8A7779 code.

Ahh, yes, indeed

Moreover, from our prior testing, I'm afraid registering USB PHY and EHCI/OHCI in one function wouldn't work. Unless maybe if it's done from the init_late() machine's method...

Best regards
---
Kuninori Morimoto

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux