Hi Shawn, On Tue, May 28, 2013 at 11:32 PM, Shawn Guo <shawn.guo@xxxxxxxxxx> wrote: > Do you actually see the issue in real? While I'm fine with the change, > I do not think the current code will cause the issue you are describing > here, since the devm_kzalloc() of data ensures that data->reg_vbus is NULL > initially. No, I don't see the issue, but it is not good to keep data->reg_vbus and reg_vbus out of sync. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html