Am 30.05.2013 00:25, schrieb Sarah Sharp: > > On Wed, May 29, 2013 at 11:14:32PM +0200, Alexander Holler wrote: >> Current Renesas Electronics XHCI hosts (which were formerly NEC) >> do support the same vendor command to show the firmware. Rename the >> ambigious named define XHCI_NEC_HOST to XHCI_NEC_SHOW_FW because it's >> only used to display the firmware version. Besides that, change the >> output "... NEC firmware version x.y" to "... firmware version x.y" >> to not confuse owners of Renesas USB hosts. >> >> (so only cosmetic, no functional changes) > > I'm actually inclined to say you should just rip out the firmware > version code entirely. I haven't needed to use it for years, and if > Renesas changed their vendor command set, I would rather not submit > random commands to the host. > > So, can you redo this patch to just rip out XHCI_NEC_HOST and everything > that uses it? Hmm, I find the firmware version rather informational and would even display it unconditionally (instead of with xhci_debug). It prevents the need to boot Windows to checkout if the latest version is installed, especially if someone is hunting a bug. I just dont't like the name, because e.g. in my case, it made me to have a deeper look at what that quirk does, because I had the hope it might solve a problem. Therefor I think it's useful to rename it. Regards, Alexander Holler -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
