Re: [RFC 4/6] xhci: remove BUG() in xhci_get_endpoint_type()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 29, 2013 at 10:33:26AM +0900, Greg Kroah-Hartman wrote:
> On Fri, May 24, 2013 at 05:43:01PM -0700, Sarah Sharp wrote:
> > From: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
> > 
> > If the endpoint type is unknown, set it to 0 and fail gracefully
> > instead of causing a kernel panic.
> 
> How can the endpoint type be unknown?

Looking at the USB spec, there's only 2 bits for the endpoint type, so
we should never see an "unknown" endpoint type unless there's a bug in
the USB core.  The BUG() block could probably just be removed instead,
and we'll just ignore Klockwork whining about it.

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux