Hi Felipe, On Wed, May 29, 2013 at 01:25:59AM +0800, Felipe Balbi wrote: > On Tue, May 28, 2013 at 03:42:50PM +0800, Huang Rui wrote: > > This bit is removed and set as reserved in 2.50a spec. > > > > Signed-off-by: Huang Rui <ray.huang@xxxxxxx> > > so ? This driver also works on older versions of the core. What you > should do is, perhaps, add a comment saying that this bit shouldn't be > used in v2.50a+, then we need to keep an eye for any future users of > that bit and make sure that there is proper revision detection around > it. Thanks to your reply. I greped codes, in current driver didn't use this bit, and I saw that the bit is marked as reserved in 2.50a spec. I don't confirm this bit should use in v2.50a+, if it will be used or I was wrong, please correct me. I just looked at register mapping, and compared with spec and found this bit is reserved, so I send this patch to remove this define to prevent to confuse. :) Best Regards, Rui -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
