Re: [PATCH] net/usb/kalmia: use %*phC to dump small buffers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 28, 2013 at 9:14 PM, Sergei Shtylyov
<sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote:
> On 28-05-2013 13:56, Andy Shevchenko wrote:

>> @@ -263,32 +260,24 @@ kalmia_rx_fixup(struct usbnet *dev, struct sk_buff
>> *skb)
>>                                 sizeof(EXPECTED_UNKNOWN_HEADER_1)) ||
>> !memcmp(
>>                                 header_start, EXPECTED_UNKNOWN_HEADER_2,
>>                                 sizeof(EXPECTED_UNKNOWN_HEADER_2))) {
>> -                               netdev_dbg(
>> -                                       dev->net,
>> -                                       "Received expected unknown frame
>> header: %02x:%02x:%02x:%02x:%02x:%02x. Package length: %i\n",
>> -                                       header_start[0], header_start[1],
>> -                                       header_start[2], header_start[3],
>> -                                       header_start[4], header_start[5],
>> +                               netdev_dbg(dev->net,
>> +                                       "Received expected unknown frame "
>> +                                       "header: %6phC. Package length:
>> %i\n",
>
>    Message strings shouldn't be broken, despite 80 chars limit (there's an
> exception for them in checkpatch.pl).

I'm glad to hear that checkpatch.pl is eventually fixed.
Will send patch v2 tomorrow.

--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux