Re: [PATCh V10 04/12] usb: ehci: ehci-mv: use PHY driver for ehci

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, May 13, 2013 at 10:13:44AM -0400, Alan Stern wrote:
> On Mon, 13 May 2013, Chao Xie wrote:
> 
> > Originaly, ehci driver will call the callbacks in platform data
> > for PHY initialization and shut down.
> > With PHY driver, it will call the APIs provided by PHY driver
> > for PHY initialization and shutdown. It removes the callbacks
> > in platform data, and at same time it removes one block in the
> > way of enabling device tree for ehci driver.
> 
> I wonder if this is the sort of thing that should be handled in 
> ehci-hcd.c rather than in all the different platform glue drivers.
> 
> Felipe, what do you think?  Are the required actions now sufficiently 
> generic that a single source file can take care of them?

Sorry for the delay, was on business trip and now on vacations. Anyway,
I agree with you. Our PHY layer should be generic enough that it should
be usable by ehci-hcd itself. If we have any missing method, let's add
it generically.

cheers

ps: dropping this from my queue for now.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux