On Mon, 27 May 2013, Oleksij Rempel wrote: > Am 27.05.2013 17:24, schrieb Alan Stern: > > On Mon, 27 May 2013, Oleksij Rempel wrote: > > > >> Hello Alan, > >> > >> i have regression with this patch: > >> > >> commit c1fdb68e3d73741630ca16695cf9176c233be7ed > >> Author: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > >> Date: Fri Mar 22 13:30:43 2013 -0400 > >> > >> USB: EHCI: changes related to qh_refresh() > >> > >> This patch (as1638) makes several changes to the ehci-hcd driver, all > >> related to the qh_refresh() function. This function must be called > >> whenever an idle QH gets linked back into either the async or the > >> periodic schedule. > >> > >> Change a BUG_ON() in the qh_update routine to a WARN_ON(). > >> Since this code runs in atomic context, a BUG_ON() would > >> immediately freeze the whole system. > >> > >> Remove two unneeded calls to qh_refresh(), one when a QH is > >> initialized and one when a QH becomes idle. Adjust the > >> adjacent comments accordingly. > >> > >> > >> all devices seems to work fine except rts5139. It is not working an I > >> get this warnings: > > > > Are you certain this commit is responsible for the errors? How did you > > check? > > i did git bisect. But i also compared results with "git reset --hard > ..." last working version is "3.9.0-rc4-00046-gc79041a". I can't revert > this commit on current master HEAD. Hmmm. Maybe we can narrow this down. What happens if you apply only parts of the commit? For example, on top of c97041a, try applying only the hunks that change ehci-sched.c. If that works, try applying also only the last hunk affecting ehci-q.c. If that works, try applying also the two previous hunks. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
