Re: [PATCH] usb: chipidea: usbmisc_imx: Staticize usbmisc_imx_drv_init/exit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 24, 2013 at 04:38:29PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> 
> Fix the following sparse warnings:
> 
> drivers/usb/chipidea/usbmisc_imx.c:246:5: warning: symbol 'usbmisc_imx_drv_init' was not declared. Should it be static?
> drivers/usb/chipidea/usbmisc_imx.c:252:6: warning: symbol 'usbmisc_imx_drv_exit' was not declared. Should it be static?
> 

Acked-by: Shawn Guo <shawn.guo@xxxxxxxxxx>

Since we are at it, we may want to add __init/__exit for the functions
as well.

Shawn

> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> ---
>  drivers/usb/chipidea/usbmisc_imx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
> index 714a6bd..1c6610a 100644
> --- a/drivers/usb/chipidea/usbmisc_imx.c
> +++ b/drivers/usb/chipidea/usbmisc_imx.c
> @@ -243,13 +243,13 @@ static struct platform_driver usbmisc_imx_driver = {
>  	 },
>  };
>  
> -int usbmisc_imx_drv_init(void)
> +static int usbmisc_imx_drv_init(void)
>  {
>  	return platform_driver_register(&usbmisc_imx_driver);
>  }
>  subsys_initcall(usbmisc_imx_drv_init);
>  
> -void usbmisc_imx_drv_exit(void)
> +static void usbmisc_imx_drv_exit(void)
>  {
>  	platform_driver_unregister(&usbmisc_imx_driver);
>  }
> -- 
> 1.8.1.2
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux