Re: [PATCH v5 2/3] extcon: Palmas Extcon Driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Graeme/Kishon,

On Friday 24 May 2013 08:01 PM, Kishon Vijay Abraham I wrote:
From: Graeme Gregory <gg@xxxxxxxxxxxxxxx>

This is the driver for the USB comparator built into the palmas chip. It
handles the various USB OTG events that can be generated by cable
insertion/removal.


I have following feedback on this driver to use this on Tegra platform:
1. Can we have very simple driver for detecting VBUS and ID and just generate notification. No VBUS control logic or lots of USB related configurations? 2. We will need the VBUS control as optional if it is require for TI platform. Currently it is mandatory and hence it is not suite in our context. 3. There is VBUS control (enabled/disable) in VBUS detection also. When palma detect the VBUS then why actually it need to enable VBUS as VBUS is already supplied by HOST? It may be only need when palma detect the ID pin and maybe want to enable VBUS but again VBUS control (enable/disable) should be part of USB driver, out of extcon driver.



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux