Re: [PATCH] staging: dwc2: fix value of dma_mask

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Paul,

On Fri, May 24, 2013 at 04:27:56PM -0700, Paul Zimmerman wrote:
> Passing the value DMA_BIT_MASK(31) to dma_set_mask() causes the
> dwc2-pci driver to sometimes fail (cannot enumerate the connected
> device). Change it to DMA_BIT_MASK(32) instead, which is a more
> sensible value anyway.
Isn't 32 the default value usually? Not sure a about PCI devices,
though. It also made sense to set it to 31, since the comment talks
about a workaround for > 2GB ram (and 2GB ~~ 31 bits).

Or, is the workaround really only needed in the coherent mask and is
that the reason why you didn't change the coherent dma mask to 32?

If this is so, wouldn't it make sense to only set the coherent dma mask
and leave the dma mask at whatever default (just guessing here...).

Gr.

Matthijs
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux