Re: [PATCH] xhci: Add BayTrail to list of Intel switchable hosts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 24, 2013 at 10:05:01PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 05/24/2013 08:56 PM, Sarah Sharp wrote:
> 
> >>>From: "Chew, Chiau Ee" <chiau.ee.chew@xxxxxxxxx>
> >>>Like the xHCI controller on Intel Panther Point and Lynx Point
> >>>chipsets, the xHCI controller on Intel BayTrail has also ports that
> >>>can be switched between the EHCI host controller.
> >>    s/between/to/
> >Sergei, DO NOT REVIEW PATCHES TO THE XHCI DRIVER.
> 
>    OK, I'll try to follow another rule from you, though I'm getting
> tired of you telling me what not to do.

I've told you not to review patches to the xHCI driver three times now.
This is not "another rule", this is something I've asked you to avoid
already.

I've been asking you to change how you review your patches because you
can't seem to pick up on the social cues that nitpicking patches about
only grammar and random code style issues is not constructive.  You
don't seem to be getting the hint, hence the ALL CAPS and blunt words.

> >Your grammar comments and complaints about extra parenthesis are not
> >constructive and cause unnecessary patch churn.
> 
>    As if I haven't ever found more serious issues in your own XHCI patches
> (even after you forbade me to review them).

Serious issues are fine to bring up, either for my patches or for
patches that people send for the xHCI.  However, the vast majority of
comments I see from you are simply grammar comments or nitpicking of
code style that checkpatch.pl doesn't complain about.

At some point, your signal to noise ratio is so low that most kernel
developers are just going to start tuning you out.  Greg already put
your email into /dev/null.  Do you want other kernel developers to do so
as well?

If you want *serious bugs* to be acted on, then just send email about
*serious bugs*.  Or include a mix of comments about grammar/code style
in with comments about serious code issues.

Please increase your signal to noise ratio, or I will continue to send
you scathing emails when you nitpick xHCI patches.

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux