Re: [RFC PATCH 1/2] USB: OHCI: prepare to make ohci-hcd a library module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 09 May 2013, Alan Stern wrote:
> > > The #else part of this isn't needed, and I doubt very much that it
> > > would work correctly if it was needed.
> >
> > As Arnd suggestion,so I written else part.
> 
> The existing code doesn't have a #else part, and I don't think you need 
> to add one.

I had commented in an earlier (Linaro internal) review that function
declarations should not be hidden inside of an #ifdef unless there
is an #else clause defining an alternative.

I did not want to suggest with that adding an #else for the fun of it,
of course it should only be there if actually needed.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux