On Wed, 8 May 2013, Matthijs Kooijman wrote: > Hi Greg, > > > Greg, is it ok for a HCD to modify hcd->self.uses_dma like this? > perhaps you missed this question in my previous mail? :-) > > Gr. > > Matthijs > > > diff --git a/drivers/staging/dwc2/hcd.c b/drivers/staging/dwc2/hcd.c > > index d9a2055..18a91de 100644 > > --- a/drivers/staging/dwc2/hcd.c > > +++ b/drivers/staging/dwc2/hcd.c > > @@ -2766,6 +2766,9 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg, int irq, > > if (!hcd) > > goto error1; > > > > + if (hsotg->core_params->dma_enable <= 0) > > + hcd->self.uses_dma = 0; > > + > > hcd->has_tt = 1; > > > > spin_lock_init(&hsotg->lock); This is okay providing you do it before calling usb_add_hcd(). Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
