On Tue, 7 May 2013, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
>
> Fix to return -ENOMEM in the kzalloc() error handling case instead
> of 0(following platform_device_add_data() will overwrite it to 0), as
> done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> ---
> drivers/usb/gadget/dummy_hcd.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
> index a792e32..77e3023 100644
> --- a/drivers/usb/gadget/dummy_hcd.c
> +++ b/drivers/usb/gadget/dummy_hcd.c
> @@ -2661,8 +2661,10 @@ static int __init init(void)
> }
> for (i = 0; i < mod_data.num; i++) {
> dum[i] = kzalloc(sizeof(struct dummy), GFP_KERNEL);
> - if (!dum[i])
> + if (!dum[i]) {
> + retval = -ENOMEM;
> goto err_add_pdata;
> + }
> retval = platform_device_add_data(the_hcd_pdev[i], &dum[i],
> sizeof(void *));
> if (retval)
Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
