On Fri, May 3, 2013 at 6:13 AM, Vladimir Zapolskiy <vladimir_zapolskiy@xxxxxxxxxx> wrote: > This change removes calls of uvc_function_connect()/uvc_function_disconnect() > functions from open()/close() syscalls. > > This is a bugfix in g_webcam module, in some test scenarios (e.g. UDC in > suspend mode or OTG in host mode) straightforward control of D+ pull-up > might lead to system's misbehaviour. > When UDC is in suspend mode, pull-up dp is controller's behavior. Can you give an explanation how the system will go to abnormal when UDC in suspend mode or OTG in host mode? > Most probably a root cause of some reported system freezes on g_webcam > module probe [1] is related to the issue described above, for instance > if udev's v4l_id helper opens a new V4L2 device node to query device > capabilities. > > Alternatively to this chage checks may be added to UDC driver's .pullup > functions, however presence of pullup controls from uvcvideo seems to > be redundant. > > [1] http://kerneltrap.org/mailarchive/linux-usb/2010/12/29/6268355/thread > > Vladimir Zapolskiy (2): > usb: gadget/uvc: remove connect/disconnect calls on open/release > usb: gadget/uvc: remove connection/disconnection routines > > drivers/usb/gadget/f_uvc.c | 24 ------------------------ > drivers/usb/gadget/uvc.h | 3 --- > drivers/usb/gadget/uvc_v4l2.c | 5 ----- > 3 files changed, 32 deletions(-) > > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- BR, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
