Re: [PATCH v6 7/9] rcar-phy: add platform data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Apr 23, 2013 at 07:33:00PM +0400, Sergei Shtylyov wrote:
> Currently the driver hard-codes USBPCTRL0 register to 0.  It is wrong since this
> register contains board-specific USB ports configuration and so its value should
> be somehow passed via the platform data.  Add <linux/usb/rcar-phy.h> file with
> the 'struct rcar_phy_platform_data' containing various bit fields describing
> USB pin configuration.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> Acked-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> 
> ---
> Changes since version 3:
> - moved USBPCTRL0 register bit #define's to patch #9;
> - replaced USBPCTRL0 register value in the platform data structure by a set of
>   bit fields describing the configuration of the board, rewrote changelog;
> 
> Changes since version 2:
> - added #include <linux/types.h>;
> - added ACKs from Simon Horman and Kuninori Morimoto.
> 
>  include/linux/usb/rcar-phy.h |   26 ++++++++++++++++++++++++++

the new location for platform_data is include/linux/platform_data/

In fact, musb.h should move there eventually.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux