On Mon, Apr 29, 2013 at 09:02:24PM -0500, Alexandre Peixoto Ferreita wrote: > These patches implement a modification of the USBTMC protocol to allow > operation with Rigol equipment. Rigol requires that a single TMC request > to receive any buffer size and bulk requests to get the data. The > original algorithm sends a TMC request for each subset of the data (a > single USB transaction). The modification is only active for Rigol > equipment, vendor and product set is contained in the array usbtmc_id_quirk. > > The patches are tested with Rigol equipment but need more validation > with other equipment. The last patch implement an ioctl to dynamically > toggle the algorithm allowing udev to change the behavior without > recompiling the driver. Can't you trigger the quirk based on the vendor/product id of your device? We can't accept a patch that adds an ioctl just to turn a quirk on. > >From 87c5741be97d98a8f7424d3d35e1dbf758289b7b Mon Sep 17 00:00:00 2001 > From: Alexandre Peixoto Ferreira <alexandref75@xxxxxxxxx> > Date: Sun, 14 Apr 2013 20:21:31 -0500 > Subject: [PATCH 1/2] Allow usbtmc_read to interface with Rigol version of > USBTMC but preserve the original operating behavior for other equipments You need to make your Subject: shorter, and put more information (like what you wrote above, in the changelog part of the patch here. Also, you might want to break this into 3 patches, or at least something that is a bit more reviewable, as it is, this one is tough to follow. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
