On Tue, 23 Apr 2013, Arnd Bergmann wrote: > Both phy-tegra-usb.c and ehci-tegra.c export symbols used by the other one, > which does not work if one of them or both are loadable modules, resulting > in an error like: > > drivers/built-in.o: In function `utmi_phy_clk_disable': > drivers/usb/phy/phy-tegra-usb.c:302: undefined reference to `tegra_ehci_set_phcd' > drivers/built-in.o: In function `utmi_phy_clk_enable': > drivers/usb/phy/phy-tegra-usb.c:324: undefined reference to `tegra_ehci_set_phcd' > drivers/built-in.o: In function `utmi_phy_power_on': > drivers/usb/phy/phy-tegra-usb.c:447: undefined reference to `tegra_ehci_set_pts' > > This turns the interface into a one-way dependency by letting the tegra ehci > driver pass two function pointers for callbacks that need to be called by > the phy driver. > @@ -733,7 +731,9 @@ static int tegra_ehci_probe(struct platform_device *pdev) > > tegra->phy = tegra_usb_phy_open(&pdev->dev, instance, hcd->regs, > pdata->phy_config, > - TEGRA_USB_PHY_MODE_HOST); > + TEGRA_USB_PHY_MODE_HOST, > + &tegra_ehci_set_pts, > + tegra_ehci_set_phcd); Does the compiler warn about the unnecessary '&'? In any case, it looks strange to have one function pointer with an '&' and another without. Aside from that minor detail, the ehci-tegra.c changes are fine. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
