Re: [PATCH v5 1/9] ARM: shmobile: Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 21, 2013 at 11:19:28PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 04/20/2013 01:56 AM, Sergei Shtylyov wrote:
> 
> >USB EHCI, OHCI, and common PHY are the SoC devices but are wrongly defined and
> >registered in the Marzen board file.  Move the data and code to their proper
> >place in setup-r8a7779.c; while at it, we have to rename 8a7779_late_devices[]
> >to 8a7779_standard_devices[] -- this seems legitimate since they are registered
> 
>     I've been pointed to the types in the above variable names privately.
> Don't know should I resend or Simon could fix s/8a7779/r8a7779/ while
> applying... well, the USB patches haven't been ACK'ed yet.

I can fix that up.

Is the series waiting on anything?

> 
> >from r8a7779_add_standard_devices() anyway.
> >
> >Note that I'm deliberately changing the USB PHY platform device's 'id' field
> >from (previously just omitted) 0 to -1 as the device is a single of its kind.
> >
> >Note also that the board and SoC code have to be in one patch to keep the code
> >bisectable...
> >
> >The patch has been tested on the Marzen board.
> >
> >Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
> >Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> >Acked-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> 
> WBR, Sergei
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux