On Thu, Apr 11 2013, Andrzej Pietrasiewicz wrote:
> @@ -85,3 +86,4 @@ obj-$(CONFIG_USB_G_WEBCAM) += g_webcam.o
> obj-$(CONFIG_USB_G_NCM) += g_ncm.o
> obj-$(CONFIG_USB_G_ACM_MS) += g_acm_ms.o
> obj-$(CONFIG_USB_GADGET_TARGET) += tcm_usb_gadget.o
> +
If you gonna resend the patch, please drop this empty line from EOF.
> @@ -164,7 +177,8 @@ static int __init cdc_bind(struct usb_composite_dev *cdev)
> }
>
> /* set up network link layer */
> - the_dev = gether_setup(cdev->gadget, hostaddr);
> + the_dev = gether_setup(cdev->gadget, dev_addr, host_addr, hostaddr,
> + qmult);
host_addr and hostaddr? That's just confusing. Same for other places.
> if (IS_ERR(the_dev))
> return PTR_ERR(the_dev);
>
> @@ -73,6 +73,20 @@ struct gfs_ffs_obj {
>
> USB_GADGET_COMPOSITE_OPTIONS();
>
> +static unsigned qmult = QMULT_DEFAULT;
> +module_param(qmult, uint, S_IRUGO|S_IWUSR);
> +MODULE_PARM_DESC(qmult, "queue length multiplier at high/super speed");
> +
> +/* initial value, changed by "ifconfig usb0 hw ether xx:xx:xx:xx:xx:xx" */
> +static char *dev_addr;
> +module_param(dev_addr, charp, S_IRUGO);
> +MODULE_PARM_DESC(dev_addr, "Device Ethernet Address");
> +
> +/* this address is invisible to ifconfig */
> +static char *host_addr;
> +module_param(host_addr, charp, S_IRUGO);
> +MODULE_PARM_DESC(host_addr, "Host Ethernet Address");
> +
So, since all of the modules have those, should that be defined in some
u_ether.h file instead?
> static struct usb_device_descriptor gfs_dev_desc = {
> .bLength = sizeof gfs_dev_desc,
> .bDescriptorType = USB_DT_DEVICE,
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--Attachment:
pgprgSkWQ965R.pgp
Description: PGP signature
