On Wed, 17 Apr 2013, Joe Perches wrote: > On Wed, 2013-04-17 at 10:14 -0400, Alan Stern wrote: > > On Tue, 16 Apr 2013, Joe Perches wrote: > > > Reduce the size of the objects by consolidating > > > the duplicated USB_STORAGE into a single function. > [] > > Is there any reasonable way to change this so that US_DEBUGP gets > > converted to a dev_dbg call instead of a printk call? Not including > > the device identifier in the output can be a real problem if there are > > multiple mass-storage devices in the system. > > No. > > There's no standardized name of a struct device *. > struct us_data *us exists for most of them but not > all. Some have a struct isd_200 *info available, > other don't have a struct device * at all. > > Some or all US_DEBUGP calls would have to change > form. > > Perhaps a good patch would be to convert US_DEBUGP > calls where a struct us_data * is available to > to us_stor_dbg(struct us_data *, const char *fmt, ...) That would be an excellent start. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
