On Tuesday 16 April 2013, manjunath.goudar@xxxxxxxxxx wrote:
>
> -
> /*
> * On architectures with edge-triggered interrupts we must never return
> * IRQ_NONE.
> @@ -585,7 +574,6 @@ int ohci_init(struct ohci_hcd *ohci)
> return ret;
> }
> EXPORT_SYMBOL_GPL(ohci_init);
> -
> /*-------------------------------------------------------------------------*/
> diff --git a/drivers/usb/host/ohci-mem.c b/drivers/usb/host/ohci-mem.c
> index 1a4dede..f98727f 100644
> --- a/drivers/usb/host/ohci-mem.c
> +++ b/drivers/usb/host/ohci-mem.c
> @@ -30,7 +30,6 @@ void ohci_hcd_init (struct ohci_hcd *ohci)
> INIT_LIST_HEAD (&ohci->pending);
> }
> EXPORT_SYMBOL_GPL(ohci_hcd_init);
> -
> /*-------------------------------------------------------------------------*/
>
> static int ohci_mem_init (struct ohci_hcd *ohci)
No need to remove the empty lines here.
> @@ -175,7 +182,7 @@ static int ohci_quirk_amd700(struct usb_hcd *hcd)
> return 0;
> }
>
> -static void sb800_prefetch(struct ohci_hcd *ohci, int on)
> +void sb800_prefetch(struct ohci_hcd *ohci, int on)
> {
> struct pci_dev *pdev;
> u16 misc;
> @@ -187,6 +194,7 @@ static void sb800_prefetch(struct ohci_hcd *ohci, int on)
> else
> pci_write_config_word(pdev, 0x50, misc | 0x0300);
> }
> +EXPORT_SYMBOL_GPL(sb800_prefetch);
>
> /* List of quirks for OHCI */
I think this won't work when both ehci-hcd and ehci-pci are loadable modules,
since you cannot export symbols both ways. Since the function is used in
drivers/usb/host/ohci-q.c but does not actually require code from ehci-pci.c,
the easiest solution I see would be to make it a static function in ohci-q.c.
Alternatively, it could be an exported function in drivers/usb/host/pci-quirks.c.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
