Excellent. The quirk is no longer triggering resource issues. This leaves an issue with dev->enable_cnt in pci_disable_device. We still get the message 'disabling already-disabled device'. I was hoping by not having the resource errors, enable_cnt would be more accurate. This occurs after: - clean boot - hot remove devices (effectively half of machine's PCI devices) - hot add devices (returned to service as described in original mail) - hot remove devices *** this is where we get 'disabling already-disabled device' I'll dig into this tomorrow. Thank you for this first step. -----Original Message----- From: yhlu.kernel@xxxxxxxxx [mailto:yhlu.kernel@xxxxxxxxx] On Behalf Of Yinghai Lu Sent: Monday, April 15, 2013 4:41 PM To: Sarah Sharp; Bulkow, David Cc: Lawrence, Joe; linux-pci@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; Bjorn Helgaas; Rafael J. Wysocki Subject: Re: USB PCI quirk issue On Mon, Apr 15, 2013 at 11:26 AM, Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx> wrote: > Cc-ing the public Linux PCI and USB mailing lists. > > On Fri, Apr 12, 2013 at 02:59:29PM -0400, Bulkow, David wrote: >> Susan, > > I'm Sarah. :) > >> While testing Linux 3.9 we ran into an issue which I believe is a >> conflict between a couple of PCI changes. Stratus has hardware that >> can hot add/remove chunks of its PCI hierarchy which has tickled some >> of the newer code. I am mailing you because I believe the second >> change I list below holds the key. >> >> I believe we are experiencing a collision between two changes. The >> first: >> >> PCI: Put pci_dev in device tree as early as possible >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commi >> t/?id=4f535093cf8f6da8cfda7c36c2c1ecd2e9586ee4 >> >> is causing device_add to be called during pci_scan_slot. The second: >> >> USB: Fix handoff when BIOS disables host PCI device >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commi >> t/?id=cab928ee1f221c9cc48d6615070fefe2e444384a >> >> is getting activated by device_add. looks like we call quirk_final too early for hotadd path. Please check if attached can workaround the problem. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
