On Sat, 6 Apr 2013, Sergei Shtylyov wrote: > On 04/06/2013 12:40 AM, Sergei Shtylyov wrote: > > > > >> And instead of passing hcd->regs, wouldn't it be better to pass hcd? > > > > I really don't know. > > > >> Other users of this interface might need to initialize something other > >> than a non-standard register. > > > > Hm, maybe... if passing 'struct usb_hcd *' would indeed help here. > > Do you think it's > > worth passing 'struct platform_device *' along with it? > > Probably not as it can be extracted from 'hcd->self.controller'... It's up to you. Generally I think it's easier to pass an extra argument than to force the function being called to dig it out. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html