Re: [PATCH v3] xhci-mem: init list heads at the beginning of init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 04, 2013 at 10:32:13AM -0700, Sergio Aguirre wrote:
> +	INIT_LIST_HEAD(&xhci->lpm_failed_devs);
> +	INIT_LIST_HEAD(&xhci->cancel_cmd_list);
> +
>  	page_size = xhci_readl(xhci, &xhci->op_regs->page_size);
>  	xhci_dbg(xhci, "Supported page size register = 0x%x\n", page_size);
>  	for (i = 0; i < 16; i++) {
> @@ -2333,7 +2336,6 @@ int xhci_mem_init(struct xhci_hcd *xhci, gfp_t flags)
>  	xhci->cmd_ring = xhci_ring_alloc(xhci, 1, 1, TYPE_COMMAND, flags);
>  	if (!xhci->cmd_ring)
>  		goto fail;
> -	INIT_LIST_HEAD(&xhci->cancel_cmd_list);
>  	xhci_dbg(xhci, "Allocated command ring at %p\n", xhci->cmd_ring);
>  	xhci_dbg(xhci, "First segment DMA is 0x%llx\n",
>  			(unsigned long long)xhci->cmd_ring->first_seg->dma);
> @@ -2444,8 +2446,6 @@ int xhci_mem_init(struct xhci_hcd *xhci, gfp_t flags)
>  	if (xhci_setup_port_arrays(xhci, flags))
>  		goto fail;
>  
> -	INIT_LIST_HEAD(&xhci->lpm_failed_devs);
> -

Please don't remove newlines in bug fix patches.  Try again?

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux