Re: [PATCH] xhci: prevent from potential null pointer dereference on failed init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx> writes:

> Thanks for catching this!  However, the inline comment is a bit much for
> a simple NULL pointer check.  Can you remove the comment and resubmit
> this patch?

And maybe handle failure to initialize cancel_cmd_list as well? It has
the same problem.

But wouldn't it be better to move the list initializations to the
beginning of xhci_mem_init instead of relying on additional tests for a
NULL next pointer?


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux