> -----Original Message----- > From: Stephen Warren [mailto:swarren@xxxxxxxxxxxxx] > Sent: Thursday, April 04, 2013 1:06 AM > To: Venu Byravarasu > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; balbi@xxxxxx; > stern@xxxxxxxxxxxxxxxxxxx; linux-tegra@xxxxxxxxxxxxxxx; linux- > usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 6/7] usb: phy: tegra: Add error handling & clean up. > > On 04/03/2013 02:41 AM, Venu Byravarasu wrote: > > Check return values from all GPIO APIs and handle errors accordingly. > > Remove clk_disable_unprepare which is no more needed. > > checkpatch fails: As these are checkpatch warnings only, did not pay much attention on that. Any how will fix it in next update. > > > WARNING: line over 80 characters > > #27: FILE: drivers/usb/phy/phy-tegra-usb.c:547: > > + dev_err(phy->dev, "gpio %d direction not set\n", phy- > >reset_gpio); > > > > WARNING: line over 80 characters > > #34: FILE: drivers/usb/phy/phy-tegra-usb.c:553: > > + dev_err(phy->dev, "gpio %d direction not set\n", phy- > >reset_gpio); > > > > total: 0 errors, 2 warnings, 72 lines checked > > > > 0006-usb-phy-tegra-Add-error-handling-clean-up.patch has style problems, > please review. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
