On Wed, 3 Apr 2013, Christian Engelmayer wrote:
> Commit 756aa6b3d536afe85e151138cb03a293998887b3 (ehci-hub: improved
> over-current recovery) added port power cycling on overcurrent indications as
> needed by the MPC8349 USB controller after resolving of the overcurrent
> situation in order to have the host state machine assert the correct port
> status again.
>
> Commit 81463c1d707186adbbe534016cd1249edeab0dac (EHCI: only power off port if
> over-current is active) solved a thus resulting issue of endless overcurrent
> changes in combination with the MAX4967 USB power supply chip that signals
> overcurrent when power is not enabled by only powering off a port if the
> overcurrent is currently active.
>
> Added quirks flag need_oc_pp_cycle in order to specify the needed behaviour as
> there is no common behaviour that can comply with both requirements.
> Activated the quirks handling for Freescale 83xx based boards.
>
> Signed-off-by: Christian Engelmayer <christian.engelmayer@xxxxxxxxxxxxxx>
> ---
> Resubmit after comments by Alan Stern and Sergei Shtylyov:
>
> * Moved the quirks flag to the ehci driver structure instead of using a
> module parameter.
> * Kept the referenced commit titles in the patch descripton.
> * Kept the current driver behaviour in case the newly added flag is not set.
> --- a/drivers/usb/host/ehci.h
> +++ b/drivers/usb/host/ehci.h
> @@ -200,6 +200,7 @@ struct ehci_hcd { /* one per controller */
> unsigned use_dummy_qh:1; /* AMD Frame List table quirk*/
> unsigned has_synopsys_hc_bug:1; /* Synopsys HC */
> unsigned frame_index_bug:1; /* MosChip (AKA NetMos) */
> + unsigned need_oc_pp_cycle:1;
It would be nice to add a short comment to this line. Something like:
/* MPC834X port power */
Aside from that,
Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
